eh... tbh i thienk this is dead but maybe just maybe cubic is working on 1.0.6 version or hasn't had the time to chat or work on the mod... well we don't know
"hasn't had the time to chat or work on the mod" = Correct. I also haven't had the time to check this page until recently, but I'm pretty sure my schedule will fill up again..sorry.
Well, from what the report says, "FML has discovered extracted jar files in the mods directory.This breaks mod loading functionality completely.Remove the directories and replace with the jar files originally provided." It seems FML found something that isn't a mod in your mod folder, which is strange, and the report doesn't point out any mods as the cause. For now, it's a mystery.
---- Minecraft Crash Report -------- Minecraft Crash Report ----// Shall we play a game?
Time: 8/24/17 11:05 AMDescription: FML has discovered extracted jar files in the mods directory.This breaks mod loading functionality completely.Remove the directories and replace with the jar files originally provided.
java.lang.RuntimeException: Extracted mod jars found, loading will NOT continue at cpw.mods.fml.relauncher.CoreModManager.discoverCoreMods(CoreModManager.java:273) at cpw.mods.fml.relauncher.CoreModManager.handleLaunch(CoreModManager.java:221) at cpw.mods.fml.relauncher.FMLLaunchHandler.setupHome(FMLLaunchHandler.java:90) at cpw.mods.fml.relauncher.FMLLaunchHandler.setupClient(FMLLaunchHandler.java:67) at cpw.mods.fml.relauncher.FMLLaunchHandler.configureForClientLaunch(FMLLaunchHandler.java:34) at cpw.mods.fml.common.launcher.FMLTweaker.injectIntoClassLoader(FMLTweaker.java:126) at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
A detailed walkthrough of the error, its code path and all known details is as follows:---------------------------------------------------------------------------------------
-- System Details --Details: Minecraft Version: 1.7.10 Operating System: Mac OS X (x86_64) version 10.11.6 Java Version: 1.8.0_74, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation Memory: 75299304 bytes (71 MB) / 127139840 bytes (121 MB) up to 2134114304 bytes (2035 MB) JVM Flags: 5 total; -Xmx2G -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -XX:-UseAdaptiveSizePolicy -Xmn128M AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
What mods are you using? Do you have one that isn't a .jar or .zip?
That's not a very good idea. It's much better/safer to remove the old itemstack and pass in a new one.
Also don't forget to replace all existing pistons on the map and from every inventory.
What would be the best way to do that? Through NBT or one of the methods in ItemStack?
World is somewhat easy, I forgot about inventory though..and I have no clue where to begin with that one.
I went scrolling through the ItemStack code and found func_150996_a, which let's me set an ItemStack to any item. Using that, I got all the recipes to work. Now that the original pistons' crafting recipes have been removed and replaced in the creative tab, I can mark this topic as solved.
1.Why are you still not using iterators? I hope I won't have to explain how they work to you.
2. You're still not actually changing the recipes, but changing your list reference.
3. I don't see any "shaped" method. What exactly are you talking about? If you're getting a crash, post it. Preferably via pastebin.
4. Arrays are pretty basic java. Read up on them here.
1. I'm currently just trying to make them run without crashing before I start making changes.
2. See first. Changing it fixed a crash.
3. I'll post below.
4. I've used arrays before, just never in forge, just with base java and opengl. Though that article could teach me something I didn't know (Java always has it's ways of surprising me).
3. As for the list, first, you're not iterating through it correctly. It's always better to use the iterator when working with a list. Second, you're casting the list's objects to Item, however they are always ItemStack. Third, instead of running straight back here you could've taken a look at how vanilla handles this by looking at the ShapelessRecipes' methods. And fourth, lists have a method that convert them to an array, however that is not necessary since lists are better than arrays anyway.
5. You're not actually replacing the crafting items, you're replacing their references :facepalm:
1. Yes, I probably should.
3. first: Yep. second: Yeah, I have no clue why I have Item there. In the other method it's ItemStack, not Item..so at least I got one right. third: Well, I actually did..but that was around like 3 or 4 in the morning..so I didn't understand a lot of it at the time (I'm going to reread it after I post this). forth: noted.
5. Yeah, I should probably do something about that.
EDIT:
I changed the shapeless method to
if(recipe instanceof ShapelessRecipes){
List list = ((ShapelessRecipes)recipe).recipeItems;
// It's either 'list.iterator()' or 'list.listIterator()'
Iterator<List> iterator = list.iterator();
// I'll be using iterators in a little while.
for(int i1 = 0; i1 < list.size(); i1++){
ItemStack stack = (ItemStack)list.get(i1);
Item item = stack.getItem();
if(item == Item.getItemFromBlock(Blocks.piston)){
list.set(i1, Item.getItemFromBlock(MBlocks.piston));
}
if(item == Item.getItemFromBlock(Blocks.sticky_piston)){
list.set(i1, Item.getItemFromBlock(MBlocks.stickyPiston));
}
}
}
Now, this works if I get rid of the shaped method, and I haven't changed that one yet. If I don't get rid of the shaped method it crashes.
Also: ItemStack[] does not have a .set method like a list, is there an equivalent method?
1
"hasn't had the time to chat or work on the mod" = Correct. I also haven't had the time to check this page until recently, but I'm pretty sure my schedule will fill up again..sorry.
0
That sound like fun! How slow should they get? Like normal-slow or statue-slow?
1
Well, from what the report says, "FML has discovered extracted jar files in the mods directory.This breaks mod loading functionality completely.Remove the directories and replace with the jar files originally provided." It seems FML found something that isn't a mod in your mod folder, which is strange, and the report doesn't point out any mods as the cause. For now, it's a mystery.
1
Not really. The mod is still being developed, it's just taking a while. Comments are a different story.
0
There were many planned release dates, but stuff happens. There currently isn't a release date.
0
So far, I've got most of the coding done, it's just converting the models that's delaying the release.
0
What mods are you using? Do you have one that isn't a .jar or .zip?
0
Do you have a crash-report?
0
Sounds good, I'll do that.
0
What would be the best way to do that? Through NBT or one of the methods in ItemStack?
World is somewhat easy, I forgot about inventory though..and I have no clue where to begin with that one.
0
I went scrolling through the ItemStack code and found func_150996_a, which let's me set an ItemStack to any item. Using that, I got all the recipes to work. Now that the original pistons' crafting recipes have been removed and replaced in the creative tab, I can mark this topic as solved.
0
Thanks, it doesn't crash now.
0
Line 145 is
0
1. I'm currently just trying to make them run without crashing before I start making changes.
2. See first. Changing it fixed a crash.
3. I'll post below.
if(recipe instanceof ShapedRecipes){ ItemStack[] stacks = ((ShapedRecipes)recipe).recipeItems; for(int i1 = 0; i1 < stacks.length; i1++){ Item item = stacks[i1].getItem(); if(item == Item.getItemFromBlock(Blocks.piston)){ item = Item.getItemFromBlock(MBlocks.piston); } if(item == Item.getItemFromBlock(Blocks.sticky_piston)){ item = Item.getItemFromBlock(MBlocks.stickyPiston); } } }Crash (Pastebin put the java syntax on there): https://pastebin.com/i7qbY67J
4. I've used arrays before, just never in forge, just with base java and opengl. Though that article could teach me something I didn't know (Java always has it's ways of surprising me).
0
1. Yes, I probably should.
3. first: Yep. second: Yeah, I have no clue why I have Item there. In the other method it's ItemStack, not Item..so at least I got one right. third: Well, I actually did..but that was around like 3 or 4 in the morning..so I didn't understand a lot of it at the time (I'm going to reread it after I post this). forth: noted.
5. Yeah, I should probably do something about that.
EDIT:
I changed the shapeless method to
if(recipe instanceof ShapelessRecipes){ List list = ((ShapelessRecipes)recipe).recipeItems; // It's either 'list.iterator()' or 'list.listIterator()' Iterator<List> iterator = list.iterator(); // I'll be using iterators in a little while. for(int i1 = 0; i1 < list.size(); i1++){ ItemStack stack = (ItemStack)list.get(i1); Item item = stack.getItem(); if(item == Item.getItemFromBlock(Blocks.piston)){ list.set(i1, Item.getItemFromBlock(MBlocks.piston)); } if(item == Item.getItemFromBlock(Blocks.sticky_piston)){ list.set(i1, Item.getItemFromBlock(MBlocks.stickyPiston)); } } }Now, this works if I get rid of the shaped method, and I haven't changed that one yet. If I don't get rid of the shaped method it crashes.
Also: ItemStack[] does not have a .set method like a list, is there an equivalent method?