Sounds like your firewalls might be closed still. Have you allowed both Java and Minecraft through your firewalls?
You'll need to find all of the programs that manage firewalls on your computer. Windows has a built in firewall. Macs have a firewall, but it's usually disabled. Additionally, many virus software packages come with their own firewall. Norton, Symantec, and Kaspersky all have their own firewall, and you'll need to configure them all if you want your server to be reachable.
You'll need to have your goals set to let two things through your firewall:
1.) Java needs to be let through. This usually manifests itself by simply allowing the Java binary through.
2.) the Minecraft server needs to be let through, and you should be able to add a rule to open up its port. Usually you can allow 25565 through your firewall as an inbound and outbound exception to be allowed through.
Users who post here are commonly using Windows Vista or higher. Windows Vista, 7, and 8 all have a similar look when it comes to setting up windows firewall. These two videos should help you allow both Java and the Minecraft Server through a windows firewall: Java
If you have additional firewalls, or these steps didn't help you much, let us know what went wrong and where. Did anything change?
Can users on your Local Area Network (LAN) Join your server when it's running?
When you test your server, are you making sure to start your server before using a port checker?
Do you have more than one router in your network? If one router receives internet from another router in your network, then we'll need to configure both routers in order for this to work.
I did the Norton and Java stuff. But Im hosting a BUKKIT server not minecraft. although its almost the same so itll be fine
I CHECKED WITH CANYOUSEEME AND IT FINALLY SAID SUCCESS!!!!!!! THE PORTFORWARD WORKED!!!!!! NAO MY FRIENDS COULD JOIN!!!!(Dont worry I put a whitelist) IT WAS A FIREWALL ISSUE!!!!!!! THX CPTSPACETOASTER!!!!!!