Ore gen is not interrupted by this mod. In fact, I tested it with Metalurgy so I can confirm that it works.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
I'll do some more screenshots when I get back home from vacation. My laptop is not powerful enough to run Minecraft on anything more than the barest minimum settings (on the plus side, it has 4hr battery life).
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
i love mods that replace the default stone to make things interesting while mining but from my experiences mods that depend on the default stone for world generation (like biomes o plenty) to place things like miners delight (or stalagtites and stalagmites if you're using an older version of biomes o plenty) they will instead be dropped on the floor in an itemstack. I had thousands of item stacks of stalagmites when using the underground biomes mod
I can attest that combined with a MC v1.8.0 CUSTOMIZED world type and some good tweaking of the generator numbers, you can end up with this sort of beauty... (and with a bit more tweaking I have actual Mountain looking mountains, full of all sorts of ores)
I at first I used his basic 64x texture pack for the mod, but then made my own based on some of his and some real world examples combined.... that was with a View=74, a Render=21, Build=256, and Optifine Clouds=40%
Wow! That's so beautiful, Grimmliberty. May I use those screenshots on the front page?
_from my experiences mods that depend on the default stone for world generation (like biomes o plenty) to place things like miners delight (or stalagtites and stalagmites if you're using an older version of biomes o plenty) they will instead be dropped on the floor in an itemstack
Mineralogy registers the stone types in the Ore Dictionary as stone equivalents, but there's not much I can do to improve compatibility with other mods that don't use the Ore Dictionary to check stone types. I guess we'll just have to make a list of known compatibility issues.
On a different note, is there anything that you think that this mod is missing or should be improved? E.g. should I work on improving the textures of the smoothed stone blocks (I'm not a great texture artist) or should I add more block shapes (like stairs and half-slabs) or should I add more rock types or do something else?
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
The Meaning of Life, the Universe, and Everything.
Join Date:
2/14/2014
Posts:
50
Member Details
either im crazy/asleep, which havent slept in 3 days so maybe but seems like less ores spawn vs vanilla
from reading through your code, your rock class sends passes isReplaceable to stone, which doesnt have an override, so uses the default from block, which passes the check to materials, which is basicly only true for vines/snow/liquid <- don't you love the inefficiencies of java chaining 50 things to answer 1 question?
i dont think things are working as you intended
think you ment isReplaceableOreGen
It's a good thing the JVM's Just-In-Time compiler knows how to take short-cuts through nested code like that.
I didn't notice isReplaceableOreGen and that is probably what I wanted, but if the new rock types didn't count as stone for ore generation, then there'd be no ore gen at all.
Actually, I think the stone is turned into Mineralogy rocks AFTER ore gen occurs, so the issue is probably moot (except for cross-mod compatibility).
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
The Meaning of Life, the Universe, and Everything.
Join Date:
2/14/2014
Posts:
50
Member Details
now what i was told could be 100% wrong but i was told world generators get a weight, heavier ones 'tend' to sink lower in the generation order, but can still generate before other things, so....o.O
one way to tell count ores before and after fix, just saying i've been stripmining for 2 days no lapis, barely any diamond, etc, couldve been a bad seed lol
Ok, from experience, you need not worry about ore gen.
The picture you see above, in my previous post, has mountains with a height over 250 and because of the value range I added to the Generation config, I have spots of diamond and other stuff on the surface all over my map in small pockets.
This leads me to believe the stone types are replacements for the regular stone and ONLY the regular stone... though the world still has plenty of that as well.
On a different note, is there anything that you think that this mod is missing or should be improved? E.g. should I work on improving the textures of the smoothed stone blocks (I'm not a great texture artist) or should I add more block shapes (like stairs and half-slabs) or should I add more rock types or do something else?
The only thing I have noticed is what I assume are 'rounding errors' on my high value perlin noise generator numbers...
I get nice chunk layering and side angle sheers with your code, but every once in a while I get One Block Wide Lines of different types across the landscape...sometimes three in a row, and it looks odd, but i really think it is nothing you can help...
It is Mojang code "value type" conversion errors. I am certain, because I used to get the same sort of randomness in Better Biomes in 1.7.10.
Your code works very well, I don't think more layers would be of benefit, but you could improve textures with some real life rock sampling and making them tile-able textures.
The mineral blocks could definitely use some texture variation, sulfur is especially too smooth I think.
Personally I liked having ore colors to build with, and more would be better, but I also am thinking about it becoming 'too realistic' and the complaints that would bring. You have struck a good balance in my opinion.
The only other thing I can think of is possibly making it so the layering and sheering is configurable? So people can play with the numbers? (hee hee, because I know *I* do that all the time, hence my world gen)
Overall this is one of the best coded mods I have seen in a while. Keep it simple and concise to the original intent.
The only thing I have noticed is what I assume are 'rounding errors' on my high value perlin noise generator numbers...
I get nice chunk layering and side angle sheers with your code, but every once in a while I get One Block Wide Lines of different types across the landscape...sometimes three in a row, and it looks odd, but i really think it is nothing you can help
The perlin noise artifact is due to precision issues when interpolating a value that is too close to a control point (it is sort of like a divide-by-zero error). I figured out how to fix that in a different project I was working on (specifically, by Planet Factory program on GitHub), so I'll port the code over and see if that fixes it.
The only other thing I can think of is possibly making it so the layering and sheering is configurable? So people can play with the numbers? (hee hee, because I know *I* do that all the time, hence my world gen)
That's a good idea. I'll add it to the to-do list along with texture work and half-slabs.
Overall this is one of the best coded mods I have seen in a while. Keep it simple and concise to the original intent.
Thank you! You made be blush.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
DrCyano, could you add vanilla ores into the new stone blocks for more realism?(as opposed to effected
Thank you for reading.
he doesn't need to add them, they spawn normally. This mod replaces 'regular stone' with his stone types, so the spawns are not affected. (they are not effected either)\\
[EDIT]
sorry, I mistook what you said... now I understand, LOOK HERE .... http://minecraft.curseforge.com/mc-mods/226802-ore-gen
I am going to try it out myself...
[/EDIT]
Speaking of which, Dr.Cyano, you shouldn't have to add granite and the other 'vanilla off' stone types, just do a call for minecraft's version vs. your own and it will put them in... (oh, just got it, for version 1.8 it does, for lower version it doesn't)
[ I saw you had your own textures for them and checked and you add the blocks as well... not needed? Maybe change them to some other stone type in 1.8? ]
I've noticed that some recipes aren't working in the 1.8 version. I'm going to implement a fix for that.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
not game breaking, just needless spam to console
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
I at first I used his basic 64x texture pack for the mod, but then made my own based on some of his and some real world examples combined.... that was with a View=74, a Render=21, Build=256, and Optifine Clouds=40%
Mineralogy registers the stone types in the Ore Dictionary as stone equivalents, but there's not much I can do to improve compatibility with other mods that don't use the Ore Dictionary to check stone types. I guess we'll just have to make a list of known compatibility issues.
On a different note, is there anything that you think that this mod is missing or should be improved? E.g. should I work on improving the textures of the smoothed stone blocks (I'm not a great texture artist) or should I add more block shapes (like stairs and half-slabs) or should I add more rock types or do something else?
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Certainly. Glad to be of some small help. I truly appreciate your work.
-Grimm
from reading through your code, your rock class sends passes isReplaceable to stone, which doesnt have an override, so uses the default from block, which passes the check to materials, which is basicly only true for vines/snow/liquid <- don't you love the inefficiencies of java chaining 50 things to answer 1 question?
i dont think things are working as you intended
think you ment isReplaceableOreGen
I didn't notice isReplaceableOreGen and that is probably what I wanted, but if the new rock types didn't count as stone for ore generation, then there'd be no ore gen at all.
Actually, I think the stone is turned into Mineralogy rocks AFTER ore gen occurs, so the issue is probably moot (except for cross-mod compatibility).
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
one way to tell count ores before and after fix, just saying i've been stripmining for 2 days no lapis, barely any diamond, etc, couldve been a bad seed lol
barely any of 2nd spawned but did show that order isnt 100% the same, as it couldnt have replaced first block, yet some existed
yay for learning things lol
The picture you see above, in my previous post, has mountains with a height over 250 and because of the value range I added to the Generation config, I have spots of diamond and other stuff on the surface all over my map in small pockets.
This leads me to believe the stone types are replacements for the regular stone and ONLY the regular stone... though the world still has plenty of that as well.
The only thing I have noticed is what I assume are 'rounding errors' on my high value perlin noise generator numbers...
I get nice chunk layering and side angle sheers with your code, but every once in a while I get One Block Wide Lines of different types across the landscape...sometimes three in a row, and it looks odd, but i really think it is nothing you can help...
It is Mojang code "value type" conversion errors. I am certain, because I used to get the same sort of randomness in Better Biomes in 1.7.10.
Your code works very well, I don't think more layers would be of benefit, but you could improve textures with some real life rock sampling and making them tile-able textures.
The mineral blocks could definitely use some texture variation, sulfur is especially too smooth I think.
Personally I liked having ore colors to build with, and more would be better, but I also am thinking about it becoming 'too realistic' and the complaints that would bring. You have struck a good balance in my opinion.
The only other thing I can think of is possibly making it so the layering and sheering is configurable? So people can play with the numbers? (hee hee, because I know *I* do that all the time, hence my world gen)
Overall this is one of the best coded mods I have seen in a while. Keep it simple and concise to the original intent.
The perlin noise artifact is due to precision issues when interpolating a value that is too close to a control point (it is sort of like a divide-by-zero error). I figured out how to fix that in a different project I was working on (specifically, by Planet Factory program on GitHub), so I'll port the code over and see if that fixes it.
That's a good idea. I'll add it to the to-do list along with texture work and half-slabs.
Thank you! You made be blush.
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
bit much? ok stair/slab for the base rock
btw.....i'm soooo kawaiiii!!!!
he doesn't need to add them, they spawn normally. This mod replaces 'regular stone' with his stone types, so the spawns are not affected. (they are not effected either)\\
[EDIT]
sorry, I mistook what you said... now I understand, LOOK HERE .... http://minecraft.curseforge.com/mc-mods/226802-ore-gen
I am going to try it out myself...
[/EDIT]
Speaking of which, Dr.Cyano, you shouldn't have to add granite and the other 'vanilla off' stone types, just do a call for minecraft's version vs. your own and it will put them in... (oh, just got it, for version 1.8 it does, for lower version it doesn't)
[ I saw you had your own textures for them and checked and you add the blocks as well... not needed? Maybe change them to some other stone type in 1.8? ]
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes