Can't you just use java reflection to force read/edit said variables.
PS: I was intending on trying to make reverb for Minecraft and putting it in my mod but seeing as you've pulled it off so well I'll just direct my community to you.
Yeah, that's probably what I'll end up doing. I think I've narrowed it down to one line where I would have to edit.
Updated to 1.7 already? Tmtravlr, will you ever cease to amaze me?
Yeah, I found a way to do it that didn't involve editing any variables. I statically replaced the default library in the SoundSystemConfig before anything starts loading. I actually found that in the 1.6 version (while trying to fix that crash), and noticed that it would still work in 1.7. =)
The Meaning of Life, the Universe, and Everything.
Join Date:
2/23/2012
Posts:
260
Location:
Locked in my room
Minecraft:
Lif3less
Member Details
This is such a cool mod. See how small things like this change the experience in minecraft, like going to the cave isn't like being outside anymore and feels so "closed in". Gratz on updating this to 1.7 ^^
could you make a config option to make the reverb louder/ more noticeable? like if I'm being attacked by a load of zombies in a cave I don't really notice it that much.
Rollback Post to RevisionRollBack
If you want a quicker reply from me then be sure to hit the Reply button.
could you make a config option to make the reverb louder/ more noticeable? like if I'm being attacked by a load of zombies in a cave I don't really notice it that much.
It's actually maxed out if you're in a cave with lots of stone around. It's hard to hear if a lot of the same sounds are playing at once because the sounds blend together.
Great mod! Although, could you make the sounds a little more noticeable? Also, could you implement surround sound, kind of like this?
It bugs me that Minecraft's noises sound like they are happening in front of you, rather than around you.
Great mod! Although, could you make the sounds a little more noticeable? Also, could you implement surround sound, kind of like this?
It bugs me that Minecraft's noises sound like they are happening in front of you, rather than around you.
What do you think should be more noticeable?
Stereo sounds are already in the game though. If you mean sounds for more than 2 speakers, that would be really neat, but I don't think I would do it because this mod is about applying filters to sounds.
Quote from Tmtravlr»
Stereo sounds are already in the game though. If you mean sounds for more than 2 speakers, that would be really neat, but I don't think I would do it because this mod is about applying filters to sounds.
By "stereo sounds," it means changing the direction the sound appears to be coming from in your speakers. While it is implemented in the game currently, it's not done very well. Sounds still seem to come mostly from the front, no matter what direction they're actually coming from. Perhaps you could apply a filter to occlude sounds slightly when they're not in your cone of vision? I'm not sure how doable that would be, though...
Are things supposed to be echoing, even outside? Seems kind of weird to me that everything sounds like I'm in a tunnel, just because I'm on stone blocks. I can understand if I'm underneath a mountain or something, but there's nothing but sky above me.
By "stereo sounds," it means changing the direction the sound appears to be coming from in your speakers. While it is implemented in the game currently, it's not done very well. Sounds still seem to come mostly from the front, no matter what direction they're actually coming from. Perhaps you could apply a filter to occlude sounds slightly when they're not in your cone of vision? I'm not sure how doable that would be, though...
Ah, I see. I haven't noticed that; I've never had a problem telling which direction the sound is coming from.
I think the only way to improve it would be to pan the sounds more noticeably to the two speakers (as in sounds to the right of you don't go to the left speaker at all, though that's less realistic), but I've looked through the sound libraries, and it wouldn't be easy to do.
Are things supposed to be echoing, even outside? Seems kind of weird to me that everything sounds like I'm in a tunnel, just because I'm on stone blocks. I can understand if I'm underneath a mountain or something, but there's nothing but sky above me.
Yeah, it will echo there right now. It's based on the blocks around you, so if you're in a biome with lots of stone around, it will echo outside. I might find a way to fix that eventually, but for now, rocky biomes will be quite echoey (which is kind of realistic, isn't it?).
Yeah, that's probably what I'll end up doing. I think I've narrowed it down to one line where I would have to edit.
Great =), I'm glad you liked it.
Go ahead and use it. Just make sure you list me as the author and link back to the main forum post, so people know where it came from and such. =)
But first.. Crash Report: http://pastebin.com/ym2FTySr
I don't really know what Patreon is, but I can try to create a page.
Grr, I thought I fixed that crash. Here, I changed how it works, so it shouldn't ever be possible to crash there from now on.
Version 0.3: http://minecraft.curseforge.com/mc-mods/222789-sound-filters/files/2210202/download
So apparently crashing was still possible. =/ Try version 0.3.
Well, you won't have to wait long...
1.7 has been conquered. =D
Version 0.4 is out; I made a version for both 1.6 and 1.7 (I also updated the 1.6 version to 0.4 because I found another potential crash).
0.4 for 1.6: http://minecraft.curseforge.com/mc-mods/222789-sound-filters/files/2210221/download
0.4 for 1.7: http://minecraft.curseforge.com/mc-mods/222789-sound-filters/files/2210222/download
The 1.7 version acts exactly like the 1.6 version right now.
And I didn't even have to use reflection or ASM! =)
This... is, SOUNDS... amazing !!!
Yeah, I found a way to do it that didn't involve editing any variables. I statically replaced the default library in the SoundSystemConfig before anything starts loading. I actually found that in the 1.6 version (while trying to fix that crash), and noticed that it would still work in 1.7. =)
"For they conquer who believe they can"
I'm going to take this baby for a test run right now. Grats on winning the code battle and thanks for the update.
If you want a quicker reply from me then be sure to hit the Reply button.
It's actually maxed out if you're in a cave with lots of stone around. It's hard to hear if a lot of the same sounds are playing at once because the sounds blend together.
It bugs me that Minecraft's noises sound like they are happening in front of you, rather than around you.
What do you think should be more noticeable?
Stereo sounds are already in the game though. If you mean sounds for more than 2 speakers, that would be really neat, but I don't think I would do it because this mod is about applying filters to sounds.
If she wants the shaft, she must play the Craft.
By "stereo sounds," it means changing the direction the sound appears to be coming from in your speakers. While it is implemented in the game currently, it's not done very well. Sounds still seem to come mostly from the front, no matter what direction they're actually coming from. Perhaps you could apply a filter to occlude sounds slightly when they're not in your cone of vision? I'm not sure how doable that would be, though...
Ah, I see. I haven't noticed that; I've never had a problem telling which direction the sound is coming from.
I think the only way to improve it would be to pan the sounds more noticeably to the two speakers (as in sounds to the right of you don't go to the left speaker at all, though that's less realistic), but I've looked through the sound libraries, and it wouldn't be easy to do.
Yeah, it will echo there right now. It's based on the blocks around you, so if you're in a biome with lots of stone around, it will echo outside. I might find a way to fix that eventually, but for now, rocky biomes will be quite echoey (which is kind of realistic, isn't it?).
(Next to add : Ambiance? If so not too much bird chirping please, that's just annoying)