Minecraft Forums

Quote from darkdaynight

Does anyone know how to make items appear in generated chests?

Quote from cowmonkey

mines horrible, i can only play minecraft on bad settings, it always has a gray screen come up called kernal panic, and it always freezes..

Quote from harrynoob

You obviously didn't post the entire file. I don't see a 35th line anywhere so... Anyway, just replace the Item() with Item

Quote from cowmonkey

hmmm, i will fix it

but whats that

////////////////////////////////////////////
for??

Quote from Younga_Henrik

I would like to know :biggrin.gif:

world.setBlockWithNotify(i, j, k, Block.chest.blockID);
TileEntityChest tileentitychest = (TileEntityChest)world.getBlockTileEntity(i, j, k);
ItemStack itemstack = pickCheckLootItem(rand);
tileentitychest.setInventorySlotContents(rand.nextInt(tileentitychest.getSizeInventory()), itemstack);

 private ItemStack pickCheckLootItem(Random rand)
   {
       int i = rand.nextInt(11);
       if(i == 0)
       {
           return new ItemStack(Item.saddle);
       }
       if(i == 1)
       {
           return new ItemStack(Item.ingotIron, rand.nextInt(4) + 1);
       }
       if(i == 2)
       {
           return new ItemStack(Item.bread);
       }
       if(i == 3)
       {
           return new ItemStack(Item.wheat, rand.nextInt(4) + 1);
       }
       if(i == 4)
       {
           return new ItemStack(Item.gunpowder, rand.nextInt(4) + 1);
       }
       if(i == 5)
       {
           return new ItemStack(Item.silk, rand.nextInt(4) + 1);
       }
       if(i == 6)
       {
           return new ItemStack(Item.bucketEmpty);
       }
       if(i == 7 && rand.nextInt(100) == 0)
       {
           return new ItemStack(Item.appleGold);
       }
       if(i == 8 && rand.nextInt(2) == 0)
       {
           return new ItemStack(Item.redstone, rand.nextInt(4) + 1);
       }
       if(i == 9 && rand.nextInt(10) == 0)
       {
           return new ItemStack(Item.itemsList[Item.record13.shiftedIndex + rand.nextInt(2)]);
       }
       if(i == 10)
       {
           return new ItemStack(Item.dyePowder, 1, 3);
       } else
       {
           return null;
       }
   }

Quote from Younga_Henrik

I have tryd to copy the code from dungeon chest, but it just crashed when i started a new world, but im gonna try your code now. Thanks! :biggrin.gif:

Quote from Younga_Henrik

Did it work for you? :biggrin.gif:

Quote from darkdaynight

Thanks the first one worked. Then I tried the second one to see what it would do and minecraft crashed.

     for (;world.getBlockId(i,j,k) == 0;++j) {} 
     j--;

Quote from Groxmapper

Odd, I was sure I did it correctly. Still if I didn't you could try this:

     for (;world.getBlockId(i,j,k) == 0;++j) {} 
     j--;

Keep in mind the other might be right but your code generation is too complex or uses variables or something that could interfere or conflict with this. I can't be sure since I don't have that code in front of me.

Quote from Groxmapper

Odd, I was sure I did it correctly. Still if I didn't you could try this:

     for (;world.getBlockId(i,j,k) == 0;++j) {} 
     j--;

Keep in mind the other might be right but your code generation is too complex or uses variables or something that could interfere or conflict with this. I can't be sure since I don't have that code in front of me.

Quote from darkdaynight

I just tried your code with a simpler one block generation and minecraft still crashed.

Quote from Merk Gamer

package net.minecraft.src;

import java.util.*;
import java.util.Random;

public class mod_MerkgamerSC2 extends BaseMod
{
	public static final Item PsiBlade = new ItemPsiBlade(1505, 0).setItemName("PsiBlade");
	public static final Item PsiBladeShard = new ItemPsiBladeShard(1506, 0).setItemName("PsiBladeShard");
	public static final Item GasContainer = new Item(1504).setItemName("GasContainer");
	public static final Item Gas = new ItemGas(1503, 0).setItemName("Gas");
	public static final Item MineralShard = new ItemFood(1501, 3, false).setItemName("MineralShard");
	public static final Item MineralChunk = new Item(1500).setItemName("MineralChunk");
	public static final BlockFlower MineralOre = (BlockFlower) new BlockFlower(180, 0).setHardness(0.5F).setStepSound(Block.soundGlassFootstep).setBlockName("MineralOre");
	public static final Item HarvesterPickaxe = new ItemPickaxeHarvester(1502, EnumToolHarvester.HARVESTER).setItemName("Harvester");

public mod_MerkgamerSC2()
{
	ModLoader.RegisterEntityID(EntityZealot.class, "Zealot", ModLoader.getUniqueEntityId());
	
	ModLoader.RegisterBlock(MineralOre);
	
	ModLoader.AddName(PsiBladeShard, "PsiBladeEssence");
	ModLoader.AddName(PsiBlade, "PsiBlade");
	ModLoader.AddName(GasContainer, "GasContainer");
	ModLoader.AddName(Gas, "Gas");
	ModLoader.AddName(HarvesterPickaxe, "Harvester");
	ModLoader.AddName(MineralOre, "MineralOre");
	ModLoader.AddName(MineralShard,  "MineralShard");
	ModLoader.AddName(MineralChunk, "MineralChunk");
	
	PsiBladeShard.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/PsiBladeShard.png");
	PsiBlade.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/PsiBlade.png");
	GasContainer.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/GasContainer.png");
	Gas.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/Gas.png");
	MineralOre.blockIndexInTexture = ModLoader.addOverride("/terrain.png", "/Merkgamer/Mineral.png");
	MineralShard.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/MineralShard.png");
	MineralChunk.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/MineralChunk.png");
	HarvesterPickaxe.iconIndex = ModLoader.addOverride("/gui/items.png", "/Merkgamer/Harvester.png");
	
	ModLoader.AddSpawn("Zealot", 3, EnumCreatureType.monster, new BiomeGenBase[] {
            BiomeGenBase.iceDesert,
            BiomeGenBase.taiga,
            BiomeGenBase.forest,
            BiomeGenBase.plains,
            BiomeGenBase.rainforest,
            BiomeGenBase.tundra,
	}); 
	
	ModLoader.AddRecipe(new ItemStack(MineralShard, 2), new Object [] {
		"   ", " X ", "   ",
		Character.valueOf('X'), MineralOre
	});
	ModLoader.AddRecipe(new ItemStack(MineralChunk, 1), new Object [] {
		"XXX", "X X", "XXX",
		Character.valueOf('X'), MineralOre
	});
	ModLoader.AddRecipe(new ItemStack(MineralShard, 18), new Object [] {
		"XXX", "XXX", "XXX",
		Character.valueOf('X'), MineralOre
	});
	ModLoader.AddRecipe(new ItemStack(HarvesterPickaxe, 1), new Object [] {
		" M ", "GDG", " D ",
		Character.valueOf('M'), MineralChunk,
		Character.valueOf('G'), GasContainer,
		Character.valueOf('D'), Item.ingotIron,
	});
	ModLoader.AddRecipe(new ItemStack(GasContainer, 1), new Object [] {
		"XXX", "XXX", "XXX",
		Character.valueOf('X'), Gas
	});
	ModLoader.AddRecipe(new ItemStack(PsiBlade, 1), new Object [] {
		"PMP", "PMP", " I ",
		Character.valueOf('P'), PsiBladeShard,
		Character.valueOf('M'), MineralChunk,
		Character.valueOf('I'), Item.ingotIron,
	});
}
public String Version ()
{
	return"1.7.3";
}
public void AddRenderer(Map map)
{
    map.put(EntityZealot.class, new RenderZealot(new ModelZealot(), 0.5F)); 
}
public void GenerateSurface(World var1, Random var2, int var3, int var4)
{
	int var5;
	int var6;
	int var7;
	int var8;
	for(var5 = 0; var5 < 2; ++var5)
	{
		var6 = var3 + var2.nextInt(3) + 8;
		var7 = var2.nextInt (128);
		var8 = var4 + var2.nextInt(3) + 8;
		new WorldGenFlowers(mod_MerkgamerSC2.MineralOre.blockID).generate(var1, var2, var6, var7, var8);
	}
}
}

Now this all works good except for my flower not returning my mineral texture when destroyed my flower is called MineralOre and when destroyed and picked up it gives me the texture of a side of the stone but it still works in everything and in inventory editor it doesn't have the texture but when it spawns in the world it does have my MineralOre texture also if you have any suggestions from my code feel free to tear it apart this is a learning process. Please help... I also would greatly appreciate a tutorial on creating a mob that is similar to a creeper but detonates instantly and has bigger radius.

public static final itemName = (new ItemName(500, 0)).setIconCoord(0, 0).setItemName("itemName");

public static final itemName = (new ItemReed(500, blockItemBecomesNameHere)).setIconCoord(0, 0).setItemName("itemName");

Quote from Groxmapper

Well the reason for the flower being a big grey flat block is that it doesn't have an ITEM version. Just a block for the flower won't work. (Normally it does but only if it's an OPAQUE cube, ie no transparency. Example: reeds have this; they have 2 textures, one for the item you hold one for the block itself)

You would have to change the block version to drop the item instead of the block. The item would simply place the block version when right clicked, but you can simply change the line that looks similar to this:

public static final itemName = (new ItemName(500, 0)).setIconCoord(0, 0).setItemName("itemName");

Into this:

public static final itemName = (new ItemReed(500, blockItemBecomesNameHere)).setIconCoord(0, 0).setItemName("itemName");

ItemReed simply handles the process for you, it doesn't grow, it doesn't have any other properties exept placement. (cake also uses it like this, which I found funny. :tongue.gif:)

Quote from cowmonkey

thanks for helping everyone :biggrin.gif:

good job :smile.gif:

    public int getBlockTexture(IBlockAccess iblockaccess, int i, int j, int k, int l)
    {
        if(l == 1)
        {
            return blockIndexInTexture + 1;
        }
        if(l == 0)
        {
            return blockIndexInTexture + 1;
        }
        int i1 = iblockaccess.getBlockMetadata(i, j, k);
        if(l != i1)
        {
            return blockIndexInTexture;
        }
      return blockIndexInTexture;
    }